Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WalletDropdownFundLink #1021

Merged
merged 51 commits into from
Aug 15, 2024
Merged

feat: WalletDropdownFundLink #1021

merged 51 commits into from
Aug 15, 2024

Conversation

0xAlec
Copy link
Contributor

@0xAlec 0xAlec commented Aug 9, 2024 •
edited
Loading

What changed? Why?

  • add WalletDropdown component that links to https://keys.coinbase.com/funding flow for a Coinbase Smart Wallet.
  • has override able text, icon, classname, and different methods (popup vs. link)
  • add docs

Notes to reviewers

  • add component docs in next PR

How has it been tested?
locally

Size md

image image

Size sm

image image

@github-actions github-actions bot added documentation Improvements or additions to documentation pkg: wallet labels Aug 9, 2024
@0xAlec 0xAlec force-pushed the alec/fund-wallet branch from e312949 to 540d0d3 Compare August 9, 2024 16:41
@vercel Vercel
Copy link

vercel bot commented Aug 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 1:13am

@0xAlec 0xAlec changed the title Alec/fund wallet feat: WalletDropdownFundLink Aug 9, 2024
@0xAlec 0xAlec marked this pull request as ready for review August 9, 2024 17:13
Zizzamia
Zizzamia reviewed Aug 15, 2024
View reviewed changes
src/wallet/components/WalletDropdownFundLink.tsx
import type { WalletDropdownFundLinkReact } from '../types';
import { getWindowDimensions } from '../utils/getWindowDimensions';

export function WalletDropdownFundLink({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in new diff, updated in types.mdx as well

Zizzamia
Zizzamia approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@Zizzamia Zizzamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, great job!!!!

@Zizzamia Zizzamia merged commit 1864361 into main Aug 15, 2024
14 checks passed
@Zizzamia Zizzamia deleted the alec/fund-wallet branch August 15, 2024 01:15
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zizzamia Zizzamia Zizzamia approved these changes

@abcrane123 abcrane123 Awaiting requested review from abcrane123

@cpcramer cpcramer Awaiting requested review from cpcramer

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pkg: wallet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xAlec @Zizzamia @cpcramer @abcrane123